- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 33.7k
 
doc: use destructuring in code examples #13349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
    
                
     Closed
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    addaleax
  
              
              approved these changes
              
                  
                    May 31, 2017 
                  
              
              
            
            
              
                    hiroppy
  
              
              approved these changes
              
                  
                    May 31, 2017 
                  
              
              
            
            
              
                    TimothyGu
  
              
              approved these changes
              
                  
                    May 31, 2017 
                  
              
              
            
            
              
                    watilde
  
              
              approved these changes
              
                  
                    Jun 1, 2017 
                  
              
              
            
            
              
                    lpinca
  
              
              approved these changes
              
                  
                    Jun 1, 2017 
                  
              
              
            
            
              
                    gibfahn
  
              
              approved these changes
              
                  
                    Jun 1, 2017 
                  
              
              
            
            
              
                    cjihrig
  
              
              approved these changes
              
                  
                    Jun 1, 2017 
                  
              
              
            
            
              
                    mhdawson
  
              
              approved these changes
              
                  
                    Jun 1, 2017 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
              
                    tniessen
  
              
              approved these changes
              
                  
                    Jun 1, 2017 
                  
              
              
            
            
              
                    jasnell
  
              
              approved these changes
              
                  
                    Jun 1, 2017 
                  
              
              
            
            
| 
           Landed in 7de6998  | 
    
    
  vsemozhetbyt 
      added a commit
      that referenced
      this pull request
    
      Jun 2, 2017 
    
    
      
  
    
      
    
  
PR-URL: #13349 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
    
  jasnell 
      pushed a commit
      that referenced
      this pull request
    
      Jun 5, 2017 
    
    
      
  
    
      
    
  
PR-URL: #13349 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
      
     Closed
  
      
        
      
      
  
    3 tasks
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Checklist
Affected core subsystem(s)
doc